Code Refactor in C#

AliYilma...

SOLVED CLOSED ACTIVE ANSWERED
User: AliYilmaz
Posted: on Dec 26, 2023 10:00 PM
Forum: ASP.Net Web Forms
Answer: 1
Views: 839

Hi,

Hello, if we want to rewrite this code again, how can we write it? I would be happy if you help.

Code

public string GetCountOfFilesForCharts(FileCountForChartRequest req)
{
    if (req.Type == FileCountType.Opened)
    {
        if (req.Grouping == FileCountGroup.Daily)
        {
            var dates = Enumerable.Range(0, (DateTime.Now - req.StartDate).Days + 1)
            .Select(offset => req.StartDate.AddDays(offset))
            .ToList();
            var dailyLogCounts = dates.Select(cartcurt => new
            {
                Date = cartcurt,
                Count = _fileLogService.Entities.Count(fl => fl.CreateDate <= cartcurt.Date.AddDays(1) && fl.CreateDate >= cartcurt.Date && fl.StatusId == 1 && fl.FileId != 0)
            });
            string sonuc = "";
            foreach (var logCount in dailyLogCounts)
            {
                sonuc += $"{logCount.Date.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n";
            }
            return sonuc;
        }
        else if (req.Grouping == FileCountGroup.Weekly)
        {
            var dates = Enumerable.Range(0, (DateTime.Now - req.StartDate).Days / 7 + 1)
            .Select(offset => req.StartDate.AddDays(offset * 7))
            .ToList();
            var weeklyLogCounts = dates.Select(weekStart => new
            {
                WeekStart = weekStart,
                Count = _fileLogService.Entities.Count(fl => fl.CreateDate < weekStart.Date.AddDays(7) && fl.CreateDate >= weekStart.Date && fl.StatusId == 1 && fl.FileId != 0)
            });
            string sonuc = "";
            foreach (var logCount in weeklyLogCounts)
            {
                sonuc += $"Hafta başı {logCount.WeekStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n";
            }
            return sonuc;
        }
        else if (req.Grouping == FileCountGroup.Monthly)
        {
            var dates = Enumerable.Range(0, (DateTime.Now.Year - req.StartDate.Year) * 12 + DateTime.Now.Month - req.StartDate.Month + 1)
            .Select(offset => new DateTime(req.StartDate.Year, req.StartDate.Month, 1).AddMonths(offset))
            .ToList();
            var monthlyLogCounts = dates.Select(monthStart => new
            {
                MonthStart = monthStart,
                Count = _fileLogService.Entities.Count(fl =>
                fl.CreateDate >= monthStart &&
                fl.CreateDate < monthStart.AddMonths(1) &&
                fl.StatusId == 1 &&
                fl.FileId != 0)
            });
            string sonuc = "";
            foreach (var logCount in monthlyLogCounts)
            {
                sonuc += $"Ay başı {logCount.MonthStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n";
            }
            return sonuc;
        }
        else if (req.Grouping == FileCountGroup.Yearly)
        {
            var dates = Enumerable.Range(0, DateTime.Now.Year - req.StartDate.Year + 1)
            .Select(offset => new DateTime(req.StartDate.Year, 1, 1).AddYears(offset))
            .ToList();
            var yearlyLogCounts = dates.Select(yearStart => new
            {
                YearStart = yearStart,
                Count = _fileLogService.Entities.Count(fl =>
                fl.CreateDate >= yearStart &&
                fl.CreateDate < yearStart.AddYears(1) &&
                fl.StatusId == 1 &&
                fl.FileId != 0)
            });
            string sonuc = "";
            foreach (var logCount in yearlyLogCounts)
            {
                sonuc += $"Yıl başı {logCount.YearStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n";
            }
            return sonuc;
        }
        return "";
    }

    if (req.Type == FileCountType.Closed)
    {
        if (req.Grouping == FileCountGroup.Daily)
        {
            var dates = Enumerable.Range(0, (DateTime.Now - req.StartDate).Days + 1)
            .Select(offset => req.StartDate.AddDays(offset))
            .ToList();
            var dailyLogCounts = dates.Select(cartcurt => new
            {
                Date = cartcurt,
                Count = _fileLogService.Entities.Count(fl => fl.CreateDate <= cartcurt.Date.AddDays(1) && fl.CreateDate >= cartcurt.Date && fl.StatusId == 10 && fl.FileId != 0)
            });
            string sonuc = "";
            foreach (var logCount in dailyLogCounts)
            {
                sonuc += $"{logCount.Date.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n";
            }
            return sonuc;
        }
        else if (req.Grouping == FileCountGroup.Weekly)
        {
            var dates = Enumerable.Range(0, (DateTime.Now - req.StartDate).Days / 7 + 1)
            .Select(offset => req.StartDate.AddDays(offset * 7))
            .ToList();
            var weeklyLogCounts = dates.Select(weekStart => new
            {
                WeekStart = weekStart,
                Count = _fileLogService.Entities.Count(fl => fl.CreateDate < weekStart.Date.AddDays(7) && fl.CreateDate >= weekStart.Date && fl.StatusId == 10 && fl.FileId != 0)
            });
            string sonuc = "";
            foreach (var logCount in weeklyLogCounts)
            {
                sonuc += $"Hafta başı {logCount.WeekStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n";
            }
            return sonuc;
        }
        else if (req.Grouping == FileCountGroup.Monthly)
        {
            var dates = Enumerable.Range(0, (DateTime.Now.Year - req.StartDate.Year) * 12 + DateTime.Now.Month - req.StartDate.Month + 1)
            .Select(offset => new DateTime(req.StartDate.Year, req.StartDate.Month, 1).AddMonths(offset))
            .ToList();
            var monthlyLogCounts = dates.Select(monthStart => new
            {
                MonthStart = monthStart,
                Count = _fileLogService.Entities.Count(fl =>
                fl.CreateDate >= monthStart &&
                fl.CreateDate < monthStart.AddMonths(1) &&
                fl.StatusId == 10 &&
                fl.FileId != 0)
            });
            string sonuc = "";
            foreach (var logCount in monthlyLogCounts)
            {
                sonuc += $"Ay başı {logCount.MonthStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n";
            }
            return sonuc;
        }
        else if (req.Grouping == FileCountGroup.Yearly)
        {
            var dates = Enumerable.Range(0, DateTime.Now.Year - req.StartDate.Year + 1)
            .Select(offset => new DateTime(req.StartDate.Year, 1, 1).AddYears(offset))
            .ToList();
            var yearlyLogCounts = dates.Select(yearStart => new
            {
                YearStart = yearStart,
                Count = _fileLogService.Entities.Count(fl =>
                fl.CreateDate >= yearStart &&
                fl.CreateDate < yearStart.AddYears(1) &&
                fl.StatusId == 10 &&
                fl.FileId != 0)
            });
            string sonuc = "";
            foreach (var logCount in yearlyLogCounts)
            {
                sonuc += $"Yıl başı {logCount.YearStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n";
            }
            return sonuc;
        }
    }
    return "";
}

Download FREE API for Word, Excel and PDF in ASP.Net

dharmend...

0 5

Reply
ANSWER
User: dharmendr
Replied: on Dec 28, 2023 10:51 AM
Report

Refer below code.

public string GetCountOfFilesForCharts(FileCountForChartRequest req)
{
    if (req.Type == FileCountType.Opened)
    {
        return GetFileCounts(req, 1);
    }
    else if (req.Type == FileCountType.Closed)
    {
        return GetFileCounts(req, 10);
    }
    return "";
}

private string GetFileCounts(FileCountForChartRequest req, int statusId)
{
    if (req.Grouping == FileCountGroup.Daily)
    {
        return GetDailyFileCounts(req, statusId);
    }
    else if (req.Grouping == FileCountGroup.Weekly)
    {
        return GetWeeklyFileCounts(req, statusId);
    }
    else if (req.Grouping == FileCountGroup.Monthly)
    {
        return GetMonthlyFileCounts(req, statusId);
    }
    else if (req.Grouping == FileCountGroup.Yearly)
    {
        return GetYearlyFileCounts(req, statusId);
    }
    return "";
}

private string GetDailyFileCounts(FileCountForChartRequest req, int statusId)
{
    var dates = Enumerable.Range(0, (DateTime.Now - req.StartDate).Days + 1)
        .Select(offset => req.StartDate.AddDays(offset))
        .ToList();
    var dailyLogCounts = dates.Select(date => new
    {
        Date = date,
        Count = _fileLogService.Entities.Count(fl => fl.CreateDate <= date.Date.AddDays(1) && fl.CreateDate >= date.Date && fl.StatusId == statusId && fl.FileId != 0)
    });
    string result = "";
    foreach (var logCount in dailyLogCounts)
    {
        result += $"{logCount.Date.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n";
    }
    return result;
}

private string GetWeeklyFileCounts(FileCountForChartRequest req, int statusId)
{
    var dates = Enumerable.Range(0, (DateTime.Now - req.StartDate).Days / 7 + 1)
        .Select(offset => req.StartDate.AddDays(offset * 7))
        .ToList();
    var weeklyLogCounts = dates.Select(weekStart => new
    {
        WeekStart = weekStart,
        Count = _fileLogService.Entities.Count(fl => fl.CreateDate < weekStart.Date.AddDays(7) && fl.CreateDate >= weekStart.Date && fl.StatusId == statusId && fl.FileId != 0)
    });
    string result = "";
    foreach (var logCount in weeklyLogCounts)
    {
        result += $"Hafta başı {logCount.WeekStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n";
    }
    return result;
}

private string GetMonthlyFileCounts(FileCountForChartRequest req, int statusId)
{
    var dates = Enumerable.Range(0, (DateTime.Now.Year - req.StartDate.Year) * 12 + DateTime.Now.Month - req.StartDate.Month + 1)
        .Select(offset => new DateTime(req.StartDate.Year, req.StartDate.Month, 1).AddMonths(offset))
        .ToList();
    var monthlyLogCounts = dates.Select(monthStart => new
    {
        MonthStart = monthStart,
        Count = _fileLogService.Entities.Count(fl =>
            fl.CreateDate >= monthStart &&
            fl.CreateDate < monthStart.AddMonths(1) &&
            fl.StatusId == statusId &&
            fl.FileId != 0)
    });
    string result = "";
    foreach (var logCount in monthlyLogCounts)
    {
        result += $"Ay başı {logCount.MonthStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n";
    }
    return result;
}

private string GetYearlyFileCounts(FileCountForChartRequest req, int statusId)
{
    var dates = Enumerable.Range(0, DateTime.Now.Year - req.StartDate.Year + 1)
        .Select(offset => new DateTime(req.StartDate.Year, 1, 1).AddYears(offset))
        .ToList();
    var yearlyLogCounts = dates.Select(yearStart => new
    {
        YearStart = yearStart,
        Count = _fileLogService.Entities.Count(fl =>
            fl.CreateDate >= yearStart &&
            fl.CreateDate < yearStart.AddYears(1) &&
            fl.StatusId == statusId &&
            fl.FileId != 0)
    });
    string result = "";
    foreach (var logCount in yearlyLogCounts)
    {
        result += $"Yıl başı {logCount.YearStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n";
    }
    return result;
}

I agree, here is the link: https://www.e-iceblue.com/Introduce/spire-office-for-net-free.html

Code Refactor in C#

Company

Explore

Follow us

Contact Us