Save same data into two columns in database using C# in ASP.Net

HiGeorge616,

As per your insert query you should get the 'Must declare the scalar variable "@CreatedBy".'

As in you are no passing value for CreatedBy.

There is no @Uid is defined in the insert querey for Users table but you are passing it.

Check the modified code.

protected void OnSignUp(object sender, EventArgs e)
{
    if (mailtxtbx.Text != "" & pass.Text != "" & conpass.Text != "" & txtname.Text != "")
    {
        if (pass.Text.Trim() == conpass.Text.Trim())
        {
            if (Filedoc.HasFile)
            {
                int Uid = -1;
                byte[] image;
                Stream s = Filedoc.PostedFile.InputStream;
                BinaryReader br = new BinaryReader(s);
                image = br.ReadBytes((Int32)s.Length);
                string constr = ConfigurationManager.ConnectionStrings["constr"].ConnectionString;
                using (SqlConnection con = new SqlConnection(constr))
                {
                    using (SqlCommand cmd = new SqlCommand(@"INSERT INTO Users (email, pass, con_pass, UserRole, Name, CreatedBy, image, CreateDate) 
                                            VALUES (@email,@pass,@con_pass,@UserRole,@Name,@CreatedBy,@image,@CreateDate);
                                            SELECT SCOPE_IDENTITY();"))
                    {
                        using (SqlDataAdapter sda = new SqlDataAdapter())
                        {
                            cmd.CommandType = CommandType.Text;
                            cmd.Parameters.AddWithValue("@email", mailtxtbx.Text.Trim());
                            cmd.Parameters.AddWithValue("@pass", pass.Text.Trim());
                            cmd.Parameters.AddWithValue("@con_pass", conpass.Text.Trim());
                            cmd.Parameters.AddWithValue("@UserRole", 'A');
                            cmd.Parameters.AddWithValue("@Name", txtname.Text.Trim());
                            cmd.Parameters.AddWithValue("@CreatedBy", GetInvitedBy(Convert.ToInt32(Request.QueryString["Uid"])));
                            cmd.Parameters.AddWithValue("@image", image);
                            cmd.Parameters.AddWithValue("@CreateDate", DateTime.Now);
                            cmd.Connection = con;
                            con.Open();
                            object returnObj = cmd.ExecuteScalar();
                            if (returnObj != null)
                            {
                                int.TryParse(returnObj.ToString(), out Uid);
                            }
                            con.Close();
                        }
                    }
                }
                if (Uid > 0)
                {
                    SqlConnection con = new SqlConnection(constr);
                    string query = @"INSERT INTO UserWallet (Uid, email, Name, amount) VALUES (@Uid, @email, @Name, @amount)";
                    using (SqlCommand objCMD = new SqlCommand(query, con))
                    {
                        objCMD.Parameters.AddWithValue("@Uid", Uid);
                        objCMD.Parameters.AddWithValue("@email", mailtxtbx.Text.Trim());
                        objCMD.Parameters.AddWithValue("@Name", txtname.Text.Trim());
                        objCMD.Parameters.AddWithValue("@amount", 0); //Change type here accordingly
                        con.Open();
                        objCMD.ExecuteNonQuery();
                        con.Close();
                        lblsuccess.Visible = true;
                        Div1.Visible = true;
                        lblsuccess.Text = "Successfully Signed Up";
                        lblsuccess.ForeColor = System.Drawing.Color.Green;
                        lblMessage.Visible = false;
                        dvMessage.Visible = false;
                        mailtxtbx.Text = "";
                        pass.Text = "";
                        conpass.Text = "";
                        txtname.Text = "";

                    }
                    con.Close();
                }
            }
        }
    }
}

private string GetInvitedBy(int id)
{
    string invitedBy = "";
    string constr = ConfigurationManager.ConnectionStrings["constr"].ConnectionString;
    using (SqlConnection con = new SqlConnection(constr))
    {
        using (SqlCommand cmd = new SqlCommand("SELECT email FROM Users WHERE Uid = @Id"))
        {
            cmd.CommandType = CommandType.Text;
            cmd.Parameters.AddWithValue("@Id", id);
            cmd.Connection = con;
            con.Open();
            invitedBy = Convert.ToString(cmd.ExecuteScalar());
            con.Close();
        }
    }

    return invitedBy;
}