Hi rani,

mm.Attachments.Add(new Attachment(ms, "Document.zip"));

Change above line with below.

mm.Attachments.Add(new Attachment(new MemoryStream(ms.ToArray()), "Document.zip"));

I have updated the sample aswell.

Create zip file and send in email as attachment in ASP.Net Core MVC